Remove extra backslash in unicodedata.st #3336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. I'm checking generated source (updated to 4.3.1 ST4) and it seems ok: |
|
Interesting....let me try to find out why I am getting these dangling backslashes only in our builds. |
|
I think I figured it out. We were importing StringTemplatev4 from the 4.3.1 git tag, which is missing a few fixes one of which is edge case handling of |
|
Oh shoot. I must’ve screwed up the tag with the software that got released
I guess?
On Mon, Nov 1, 2021 at 5:09 PM Justin King ***@***.***> wrote:
I think I figured it out. We were importing StringTemplatev4 from the
4.3.1 git tag, which is missing a few fixes one of which is edge case
handling of /> per antlr/stringtemplate4#198
<antlr/stringtemplate4#198>. I'll close this
for now until/if I prove myself otherwise.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3336 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABLUWORGPQ6ASBZIRS24MTUJ4T2HANCNFSM5HEYCCVQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Dictation in use. Please excuse homophones, malapropisms, and nonsense.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove extra backslash in
unicodedata.st. specifically\>. Newer versions of StringTemplate will leave the extra backslash in the source file, resulting in an invalid source.